Make view optional in the RUM common schema - #421
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoAug 5, 2026
Merged
Make view optional in the RUM common schema#421gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
barboraplasovska
marked this pull request as ready for review
August 4, 2026 14:12
BenoitZugmeyer
approved these changes
Aug 4, 2026
mariedm
approved these changes
Aug 4, 2026
simaoseica-dd
approved these changes
Aug 4, 2026
wlmsrvty
approved these changes
Aug 5, 2026
5 tasks
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
bplasovska/timeseries-optional-view
branch
August 5, 2026 09:56
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Timeseries events need to be emitted independently of a RUM view, but
viewwas required for every RUM event via_common-schema.json. SinceallOf/$refcomposition can only add requirements, not loosen them, the only way to keepviewoptional for timeseries while preserving today's behavior everywhere else is to move the requirement out of the shared base and into each event type that still needs it.